Skip to content

Remove Android-specific block editor entries from release notes#17828

Merged
mokagio merged 1 commit into
release/19.1from
fix/19.1-release-notes-remove-android-entries
Jan 27, 2022
Merged

Remove Android-specific block editor entries from release notes#17828
mokagio merged 1 commit into
release/19.1from
fix/19.1-release-notes-remove-android-entries

Conversation

@fluiddot

@fluiddot fluiddot commented Jan 27, 2022

Copy link
Copy Markdown
Contributor

We accidentally introduced Android-specific entries related to block editor changes when integrating GB-mobile 1.70.0 (#17791). This PR removes those entries as they are unrelated to WordPress-iOS app.

@fluiddot fluiddot requested a review from mokagio January 27, 2022 12:21
@fluiddot fluiddot self-assigned this Jan 27, 2022
@peril-wordpress-mobile

Copy link
Copy Markdown

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Jan 27, 2022

Copy link
Copy Markdown
Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@fluiddot fluiddot added this to the 19.1 ❄️ milestone Jan 27, 2022
@mokagio mokagio enabled auto-merge January 27, 2022 12:24

@mokagio mokagio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fluiddot 🙌

@mokagio mokagio merged commit 8566b5c into release/19.1 Jan 27, 2022
@mokagio mokagio deleted the fix/19.1-release-notes-remove-android-entries branch January 27, 2022 12:24
@mokagio

mokagio commented Jan 27, 2022

Copy link
Copy Markdown
Contributor

🤔 I enabled auto-merge, but it merged as soon as I approved... I was expecting the merge to happen after CI finished

@AliSoftware

Copy link
Copy Markdown
Contributor

@mokagio I trust you'll follow-up with a separate PR to update the release_notes.txt drafts (which Grace base her writing on) accordingly, so we can then ping her to update her copy accordingly?

@mokagio

mokagio commented Jan 27, 2022

Copy link
Copy Markdown
Contributor

@AliSoftware turns out Grace was on top of it already, but I ported the removal in bc3e11b (#17831) for the sake of tracking it in the Git history 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants